Issue in 2.7.0 with ValueInput values

[mdemaille]

Hello,

We updated flow canvas to version 2.7.0. We now have a big issue, when we change the value of a ValueInput in a node, we cannot change it back to the default value. For exemple if we set a boolean to true, and then set it back to false, it will be set to true when we enter play mode, wich is breaking the flows we updated this way.

Comment this part (see attached file) seem to resolve the issue, but we don’t know if it’s a good way to do it.

We also have this error when creating a node :

UnityException: Repaint is not allowed to be called during serialization, call it from OnEnable instead. Called from ScriptableObject ‘Macro’.
See “Script Serialization” page in the Unity Manual for further details.
UnityEditor.EditorWindow.Repaint () (at C:/buildslave/unity/build/Editor/Mono/EditorWindow.cs:752)
FlyingWormConsole3.ConsolePro3Window.RepaintOnCallback (System.String inLog, System.String inStackTrace, LogType inLogType)
UnityEngine.Application.CallLogCallback (System.String logString, System.String stackTrace, LogType type, Boolean invokedOnMainThread) (at C:/buildslave/unity/build/artifacts/generated/common/runtime/ApplicationBindings.gen.cs:564)
UnityEngine.Logger:Log(LogType, String, Object, Object)
ParadoxNotion.Services.Logger:ForwardToUnity(LogType, Object, String, Object) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Services/Logger.cs:92)
ParadoxNotion.Services.Logger:Internal_Log(LogType, Object, String, Object) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Services/Logger.cs:84)
ParadoxNotion.Services.Logger:LogError(Object, String, Object) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Services/Logger.cs:43)
ParadoxNotion.ReflectionTools:GetType(String, Boolean, Type) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Other/ReflectionTools.cs:97)
ParadoxNotion.Serialization.FullSerializer.Internal.fsTypeCache:GetType(String, Boolean, Type) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/Reflection/fsTypeCache.cs:17)
ParadoxNotion.Serialization.FullSerializer.Internal.fsTypeCache:GetType(String, Type) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/Reflection/fsTypeCache.cs:15)
ParadoxNotion.Serialization.fsRecoveryProcessor2:OnBeforeDeserialize(Type, fsData&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/fsRecoveryProcessor.cs:27)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:Invoke_OnBeforeDeserialize(List1, Type, fsData&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:169)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:InternalDeserialize_3_Inheritance(Type, fsData, Type, Object&, List1&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:801)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:InternalDeserialize_1_CycleReference(Type, fsData, Type, Object&, List1&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:744)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:TryDeserialize(fsData, Type, Type, Object&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:705)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:TryDeserialize(fsData, Type, Object&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:678)
ParadoxNotion.Serialization.FullSerializer.Internal.fsIEnumerableConverter:TryDeserialize(fsData, Object&, Type) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/Converters/fsIEnumerableConverter.cs:73)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:InternalDeserialize_5_Converter(Type, fsData, Type, Object&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:887)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:InternalDeserialize_4_Cycles(Type, fsData, Type, Object&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:879)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:InternalDeserialize_3_Inheritance(Type, fsData, Type, Object&, List1&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:858)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:InternalDeserialize_1_CycleReference(Type, fsData, Type, Object&, List1&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:744)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:TryDeserialize(fsData, Type, Type, Object&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:705)
ParadoxNotion.Serialization.FullSerializer.Internal.fsReflectedConverter:TryDeserialize(fsData, Object&, Type) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/Converters/fsReflectedConverter.cs:97)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:InternalDeserialize_5_Converter(Type, fsData, Type, Object&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:887)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:InternalDeserialize_4_Cycles(Type, fsData, Type, Object&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:879)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:InternalDeserialize_3_Inheritance(Type, fsData, Type, Object&, List1&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:858)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:InternalDeserialize_1_CycleReference(Type, fsData, Type, Object&, List1&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:744)
ParadoxNotion.Serialization.FullSerializer.fsSerializer:TryDeserialize(fsData, Type, Type, Object&) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/Full Serializer/fsSerializer.cs:705)
ParadoxNotion.Serialization.JSONSerializer:Deserialize(Type, String, List1, Object) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/JSONSerializer.cs:102)
ParadoxNotion.Serialization.JSONSerializer:Deserialize(String, List1, GraphSerializationData) (at Assets/ParadoxNotion/FlowCanvas/Framework/_Commons/Runtime/Serialization/JSONSerializer.cs:73)
NodeCanvas.Framework.Graph:Deserialize(String, Boolean, List`1) (at Assets/ParadoxNotion/FlowCanvas/Framework/Runtime/Graphs/Graph.cs:118)
NodeCanvas.Framework.Graph:Deserialize() (at Assets/ParadoxNotion/FlowCanvas/Framework/Runtime/Graphs/Graph.cs:74)
NodeCanvas.Framework.Graph:UnityEngine.ISerializationCallbackReceiver.OnAfterDeserialize() (at Assets/ParadoxNotion/FlowCanvas/Framework/Runtime/Graphs/Graph.cs:43)
UnityEditor.AssetDatabase:LoadAssetAtPath(String, Type)
FlowCanvas.FlowGraphExtensions:AppendMacroNodesMenu(FlowGraph, GenericMenu, String, Vector2, Port, Object) (at Assets/ParadoxNotion/FlowCanvas/Module/Design/FlowGraphExtensions.cs:625)
FlowCanvas.FlowGraph:OnCanvasContextMenu(GenericMenu, Vector2) (at Assets/ParadoxNotion/FlowCanvas/Module/FlowGraph.cs:175)
NodeCanvas.Framework.Graph:GetAddNodeMenu(Vector2) (at Assets/ParadoxNotion/FlowCanvas/Framework/Design/PartialEditor/EDITOR_Graph.cs:461)
NodeCanvas.Framework.Graph:HandleEvents(Event, Vector2) (at Assets/ParadoxNotion/FlowCanvas/Framework/Design/PartialEditor/EDITOR_Graph.cs:431)
NodeCanvas.Framework.Graph:ShowGraphControls(Event, Vector2) (at Assets/ParadoxNotion/FlowCanvas/Framework/Design/PartialEditor/EDITOR_Graph.cs:144)
NodeCanvas.Editor.GraphEditor:OnGUI() (at Assets/ParadoxNotion/FlowCanvas/Framework/Design/Editor/Windows/GraphEditor.cs:518)

Attachments:

You must be logged in to view attached files.

[Gavalakis]

Hello,

Even though I tested it thoroughly, it seems I missed something after all. Thanks for reporting the problem.
Yes, the change you made is absolutely fine (this is how it was on previous version).

Regarding the Repaint warning, when does exactly this show up? I can’t replicate this.

Please let me know.
Thanks.

Join us on Discord: https://discord.gg/97q2Rjh

[mdemaille]

Thank you very much for your quick answer ! The repaint warning occurs when we open unity with a canvas window openned and it happened once when we created a node with the issue above.

[Author]

Posts