Bug with Macros (flowCanvas 1.3 Unity 5.4.1f1 Personal)

[ktysdal]

Hi, my name is Kjartan and I just bought flowCanvas.
I have been playing around with it for a little bit now, and I think I found a bug with the macro system.

I started recreating a simple RTS camera and I decided to put some of the math into a macro so that I could reuse it.
You can see from the screenshot that I have the exact same Macro duplicated twice, and only one of them works (you can see based on the colors of the lines, the blue’ish ones are for some reason not working..).

Here is a link to the project files with the bug:
–link removed because it contains paid products–

Attachments:

You must be logged in to view attached files.

[ktysdal]

I have investigated a bit more and it seems like the problem is starting from the integer value from the “Get Pixel Width” node.
I made another simpler setup that also fails every time. You can see it in the screenshot.

This time I am just using a Macro that is is not doing anything (called “IntFloat”). The only thing it is doing is passing data from Float / Int data from input to output inside the macro.
The macro is simply refusing to pass data through it. If I bypass the macro and connect directly to the Set Value nodes then everything works fine.

Attachments:

You must be logged in to view attached files.

[Gavalakis]

Hello and thanks for getting FlowCanvas!

Indeed there is a bug here (introduced in last version). Thanks for finding out and for reproduction.
To fix this, please open up FlowGraph.cs and replace method OnGraphStarted() contents with the following code:

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36

protected override void OnGraphStarted(){   if (!hasInitialized){ updatableNodes = new List<IUpdatable>(); }   for (var i = 0; i < allNodes.Count; i++){ if (allNodes<em class="d4pbbc-italic"></em> is MacroNodeWrapper){ var macroNode = (MacroNodeWrapper)allNodes[ i ]; if (macroNode.macro != null){ macroNode.CheckInstance(); macroNode.macro.StartGraph(agent, blackboard, false, null); } }   if (!hasInitialized){ if (allNodes<em class="d4pbbc-italic"></em> is IUpdatable){ updatableNodes.Add( (IUpdatable)allNodes[ i ] ); } } }   if (!hasInitialized){ for (var i = 0; i < allNodes.Count; i++){ if (allNodes<em class="d4pbbc-italic"></em> is FlowNode){ var flowNode = (FlowNode)allNodes[ i ]; flowNode.AssignSelfInstancePort(); flowNode.BindPorts(); } } }   hasInitialized = true; }

Regarding sharing projects, please do not include the full FlowCanvas source code! You can email me instead if need be (support@paradoxnotion.com). Thus I’ve removed the link from your first post.

Let me know if everything works correctly for you after the fix.
Cheers!

Join us on Discord: https://discord.gg/97q2Rjh

[Gavalakis]

There seems to be something wrong with the formatting on the above piece of code. I’m sorry about that!
I’ve attached an image here to show the correct code until I fix this formatting issue.

If you have any trouble with this, please let me know and I will send you an email ASAP.
Thanks!

Join us on Discord: https://discord.gg/97q2Rjh

Attachments:

You must be logged in to view attached files.

[ktysdal]

Hello Gavalakis,
Thank you so much! The fix seems to works perfectly 🙂

Sorry about the link. I was sitting with this a bit late and I did not think that through.
Next time I will just contact you directly.

[Author]

Posts