[bug] Custom Generic Node doesn't work if isn't present in the friendly name

[daterre]

When creating custom generic nodes, none of the following works.

1 2 3 4 5 6

public class NoiseNode<NoiseT> : CallableActionNodeBase where NoiseT: NoiseBase, new() { ... }   [Name("Apply Noise")] public class NoiseNode<T> : CallableActionNodeBase where T: NoiseBase, new() { ... }

Only a single menu item is listed, not a generic menu of items. The menu item fails when selected because NoiseBase is an abstract type.

It took me about 5 hours of FlowCanvas source debugging to figure out that <T> is required in the [Name] attribute. This is undocumented and also not very robust.

1 2	[Name("Apply Noise <T>")] public class NoiseNode<T> : CallableActionNodeBase where T: NoiseBase, new()

[Gavalakis]

Hello,

I am sorry for the inconvenience. The [Name] attribute was mostly made as a mean to completely override the name of the class if required and is really not mandatory. If you just remove the [Name] attribute, the node will correctly show up in the editor as the rest of the generic nodes, with it’s class name “NoiseNode (T)”.
With that said, I just improved the [Name] attribute usage for the next version, so that it’s more convenient when used with generic nodes and it does not require “” to be manually added anymore.

Thank you!

Join us on Discord: https://discord.gg/97q2Rjh

[Author]

Posts